You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
273 lines
9.1 KiB
273 lines
9.1 KiB
/** |
|
* @author Toru Nagashima <https://github.com/mysticatea> |
|
*/ |
|
"use strict"; |
|
|
|
const { CALL, CONSTRUCT, ReferenceTracker, getStringIfConstant } = require("eslint-utils"); |
|
const { RegExpValidator, RegExpParser, visitRegExpAST } = require("regexpp"); |
|
const { isCombiningCharacter, isEmojiModifier, isRegionalIndicatorSymbol, isSurrogatePair } = require("./utils/unicode"); |
|
const astUtils = require("./utils/ast-utils.js"); |
|
|
|
//------------------------------------------------------------------------------ |
|
// Helpers |
|
//------------------------------------------------------------------------------ |
|
|
|
const REGEXPP_LATEST_ECMA_VERSION = 2022; |
|
|
|
/** |
|
* Iterate character sequences of a given nodes. |
|
* |
|
* CharacterClassRange syntax can steal a part of character sequence, |
|
* so this function reverts CharacterClassRange syntax and restore the sequence. |
|
* @param {regexpp.AST.CharacterClassElement[]} nodes The node list to iterate character sequences. |
|
* @returns {IterableIterator<number[]>} The list of character sequences. |
|
*/ |
|
function *iterateCharacterSequence(nodes) { |
|
let seq = []; |
|
|
|
for (const node of nodes) { |
|
switch (node.type) { |
|
case "Character": |
|
seq.push(node.value); |
|
break; |
|
|
|
case "CharacterClassRange": |
|
seq.push(node.min.value); |
|
yield seq; |
|
seq = [node.max.value]; |
|
break; |
|
|
|
case "CharacterSet": |
|
if (seq.length > 0) { |
|
yield seq; |
|
seq = []; |
|
} |
|
break; |
|
|
|
// no default |
|
} |
|
} |
|
|
|
if (seq.length > 0) { |
|
yield seq; |
|
} |
|
} |
|
|
|
const hasCharacterSequence = { |
|
surrogatePairWithoutUFlag(chars) { |
|
return chars.some((c, i) => i !== 0 && isSurrogatePair(chars[i - 1], c)); |
|
}, |
|
|
|
combiningClass(chars) { |
|
return chars.some((c, i) => ( |
|
i !== 0 && |
|
isCombiningCharacter(c) && |
|
!isCombiningCharacter(chars[i - 1]) |
|
)); |
|
}, |
|
|
|
emojiModifier(chars) { |
|
return chars.some((c, i) => ( |
|
i !== 0 && |
|
isEmojiModifier(c) && |
|
!isEmojiModifier(chars[i - 1]) |
|
)); |
|
}, |
|
|
|
regionalIndicatorSymbol(chars) { |
|
return chars.some((c, i) => ( |
|
i !== 0 && |
|
isRegionalIndicatorSymbol(c) && |
|
isRegionalIndicatorSymbol(chars[i - 1]) |
|
)); |
|
}, |
|
|
|
zwj(chars) { |
|
const lastIndex = chars.length - 1; |
|
|
|
return chars.some((c, i) => ( |
|
i !== 0 && |
|
i !== lastIndex && |
|
c === 0x200d && |
|
chars[i - 1] !== 0x200d && |
|
chars[i + 1] !== 0x200d |
|
)); |
|
} |
|
}; |
|
|
|
const kinds = Object.keys(hasCharacterSequence); |
|
|
|
//------------------------------------------------------------------------------ |
|
// Rule Definition |
|
//------------------------------------------------------------------------------ |
|
|
|
/** @type {import('../shared/types').Rule} */ |
|
module.exports = { |
|
meta: { |
|
type: "problem", |
|
|
|
docs: { |
|
description: "Disallow characters which are made with multiple code points in character class syntax", |
|
recommended: true, |
|
url: "https://eslint.org/docs/rules/no-misleading-character-class" |
|
}, |
|
|
|
hasSuggestions: true, |
|
|
|
schema: [], |
|
|
|
messages: { |
|
surrogatePairWithoutUFlag: "Unexpected surrogate pair in character class. Use 'u' flag.", |
|
combiningClass: "Unexpected combined character in character class.", |
|
emojiModifier: "Unexpected modified Emoji in character class.", |
|
regionalIndicatorSymbol: "Unexpected national flag in character class.", |
|
zwj: "Unexpected joined character sequence in character class.", |
|
suggestUnicodeFlag: "Add unicode 'u' flag to regex." |
|
} |
|
}, |
|
create(context) { |
|
const sourceCode = context.getSourceCode(); |
|
const parser = new RegExpParser(); |
|
|
|
/** |
|
* Verify a given regular expression. |
|
* @param {Node} node The node to report. |
|
* @param {string} pattern The regular expression pattern to verify. |
|
* @param {string} flags The flags of the regular expression. |
|
* @param {Function} unicodeFixer Fixer for missing "u" flag. |
|
* @returns {void} |
|
*/ |
|
function verify(node, pattern, flags, unicodeFixer) { |
|
let patternNode; |
|
|
|
try { |
|
patternNode = parser.parsePattern( |
|
pattern, |
|
0, |
|
pattern.length, |
|
flags.includes("u") |
|
); |
|
} catch { |
|
|
|
// Ignore regular expressions with syntax errors |
|
return; |
|
} |
|
|
|
const foundKinds = new Set(); |
|
|
|
visitRegExpAST(patternNode, { |
|
onCharacterClassEnter(ccNode) { |
|
for (const chars of iterateCharacterSequence(ccNode.elements)) { |
|
for (const kind of kinds) { |
|
if (hasCharacterSequence[kind](chars)) { |
|
foundKinds.add(kind); |
|
} |
|
} |
|
} |
|
} |
|
}); |
|
|
|
for (const kind of foundKinds) { |
|
let suggest; |
|
|
|
if (kind === "surrogatePairWithoutUFlag") { |
|
suggest = [{ |
|
messageId: "suggestUnicodeFlag", |
|
fix: unicodeFixer |
|
}]; |
|
} |
|
|
|
context.report({ |
|
node, |
|
messageId: kind, |
|
suggest |
|
}); |
|
} |
|
} |
|
|
|
/** |
|
* Checks if the given regular expression pattern would be valid with the `u` flag. |
|
* @param {string} pattern The regular expression pattern to verify. |
|
* @returns {boolean} `true` if the pattern would be valid with the `u` flag. |
|
* `false` if the pattern would be invalid with the `u` flag or the configured |
|
* ecmaVersion doesn't support the `u` flag. |
|
*/ |
|
function isValidWithUnicodeFlag(pattern) { |
|
const { ecmaVersion } = context.parserOptions; |
|
|
|
// ecmaVersion is unknown or it doesn't support the 'u' flag |
|
if (typeof ecmaVersion !== "number" || ecmaVersion <= 5) { |
|
return false; |
|
} |
|
|
|
const validator = new RegExpValidator({ |
|
ecmaVersion: Math.min(ecmaVersion + 2009, REGEXPP_LATEST_ECMA_VERSION) |
|
}); |
|
|
|
try { |
|
validator.validatePattern(pattern, void 0, void 0, /* uFlag = */ true); |
|
} catch { |
|
return false; |
|
} |
|
|
|
return true; |
|
} |
|
|
|
return { |
|
"Literal[regex]"(node) { |
|
verify(node, node.regex.pattern, node.regex.flags, fixer => { |
|
if (!isValidWithUnicodeFlag(node.regex.pattern)) { |
|
return null; |
|
} |
|
|
|
return fixer.insertTextAfter(node, "u"); |
|
}); |
|
}, |
|
"Program"() { |
|
const scope = context.getScope(); |
|
const tracker = new ReferenceTracker(scope); |
|
|
|
/* |
|
* Iterate calls of RegExp. |
|
* E.g., `new RegExp()`, `RegExp()`, `new window.RegExp()`, |
|
* `const {RegExp: a} = window; new a()`, etc... |
|
*/ |
|
for (const { node } of tracker.iterateGlobalReferences({ |
|
RegExp: { [CALL]: true, [CONSTRUCT]: true } |
|
})) { |
|
const [patternNode, flagsNode] = node.arguments; |
|
const pattern = getStringIfConstant(patternNode, scope); |
|
const flags = getStringIfConstant(flagsNode, scope); |
|
|
|
if (typeof pattern === "string") { |
|
verify(node, pattern, flags || "", fixer => { |
|
|
|
if (!isValidWithUnicodeFlag(pattern)) { |
|
return null; |
|
} |
|
|
|
if (node.arguments.length === 1) { |
|
const penultimateToken = sourceCode.getLastToken(node, { skip: 1 }); // skip closing parenthesis |
|
|
|
return fixer.insertTextAfter( |
|
penultimateToken, |
|
astUtils.isCommaToken(penultimateToken) |
|
? ' "u",' |
|
: ', "u"' |
|
); |
|
} |
|
|
|
if ((flagsNode.type === "Literal" && typeof flagsNode.value === "string") || flagsNode.type === "TemplateLiteral") { |
|
const range = [flagsNode.range[0], flagsNode.range[1] - 1]; |
|
|
|
return fixer.insertTextAfterRange(range, "u"); |
|
} |
|
|
|
return null; |
|
}); |
|
} |
|
} |
|
} |
|
}; |
|
} |
|
};
|
|
|