You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
75 lines
2.3 KiB
75 lines
2.3 KiB
/** |
|
* @fileoverview Rule to flag when initializing to undefined |
|
* @author Ilya Volodin |
|
*/ |
|
|
|
"use strict"; |
|
|
|
const astUtils = require("./utils/ast-utils"); |
|
|
|
//------------------------------------------------------------------------------ |
|
// Rule Definition |
|
//------------------------------------------------------------------------------ |
|
|
|
/** @type {import('../shared/types').Rule} */ |
|
module.exports = { |
|
meta: { |
|
type: "suggestion", |
|
|
|
docs: { |
|
description: "Disallow initializing variables to `undefined`", |
|
recommended: false, |
|
url: "https://eslint.org/docs/rules/no-undef-init" |
|
}, |
|
|
|
schema: [], |
|
fixable: "code", |
|
|
|
messages: { |
|
unnecessaryUndefinedInit: "It's not necessary to initialize '{{name}}' to undefined." |
|
} |
|
}, |
|
|
|
create(context) { |
|
|
|
const sourceCode = context.getSourceCode(); |
|
|
|
return { |
|
|
|
VariableDeclarator(node) { |
|
const name = sourceCode.getText(node.id), |
|
init = node.init && node.init.name, |
|
scope = context.getScope(), |
|
undefinedVar = astUtils.getVariableByName(scope, "undefined"), |
|
shadowed = undefinedVar && undefinedVar.defs.length > 0, |
|
lastToken = sourceCode.getLastToken(node); |
|
|
|
if (init === "undefined" && node.parent.kind !== "const" && !shadowed) { |
|
context.report({ |
|
node, |
|
messageId: "unnecessaryUndefinedInit", |
|
data: { name }, |
|
fix(fixer) { |
|
if (node.parent.kind === "var") { |
|
return null; |
|
} |
|
|
|
if (node.id.type === "ArrayPattern" || node.id.type === "ObjectPattern") { |
|
|
|
// Don't fix destructuring assignment to `undefined`. |
|
return null; |
|
} |
|
|
|
if (sourceCode.commentsExistBetween(node.id, lastToken)) { |
|
return null; |
|
} |
|
|
|
return fixer.removeRange([node.id.range[1], node.range[1]]); |
|
} |
|
}); |
|
} |
|
} |
|
}; |
|
|
|
} |
|
};
|
|
|